Re: [PATCHES] Linking on AIX (Was: Fix linking of OpenLDAP libraries ) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCHES] Linking on AIX (Was: Fix linking of OpenLDAP libraries )
Date
Msg-id 6911.1158358764@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCHES] Linking on AIX (Was: Fix linking of OpenLDAP libraries )  ("Rocco Altier" <RoccoA@Routescape.com>)
List pgsql-hackers
"Rocco Altier" <RoccoA@Routescape.com> writes:
> With the patch attached this time...

The proposed patch to Makefile.shlib makes me gag :-( ... lying to make
about what's the purpose of a rule is seldom a good idea.  Please try
as attached instead.  Also, I am *really* dubious about the change to
ecpg/test/Makefile.regress --- if that's necessary then this whole
exercise is wrong.

            regards, tom lane

*** src/Makefile.shlib.orig    Thu Apr 27 22:53:20 2006
--- src/Makefile.shlib    Fri Sep 15 18:11:30 2006
***************
*** 96,103 ****
  soname = lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION)

  ifeq ($(PORTNAME), aix)
!   shlib            = lib$(NAME)$(DLSUFFIX)
! #   SHLIB_LINK        += -lc
  endif

  ifeq ($(PORTNAME), darwin)
--- 96,103 ----
  soname = lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION)

  ifeq ($(PORTNAME), aix)
!   shlib            = lib$(NAME)$(DLSUFFIX).$(SO_MAJOR_VERSION)
!   haslibarule   = yes
  endif

  ifeq ($(PORTNAME), darwin)
***************
*** 295,303 ****
  else # PORTNAME == aix

  # AIX case
! $(shlib): lib$(NAME).a
      $(MKLDEXPORT) lib$(NAME).a > lib$(NAME)$(EXPSUFF)
!     $(COMPILER) $(LDFLAGS_NO_L) $(LDFLAGS_SL) -o $@ $< -Wl,-bE:lib$(NAME)$(EXPSUFF) $(SHLIB_LINK)

  endif # PORTNAME == aix

--- 295,307 ----
  else # PORTNAME == aix

  # AIX case
! $(shlib) lib$(NAME).a: $(OBJS)
!     $(LINK.static) lib$(NAME).a $^
!     $(RANLIB) lib$(NAME).a
      $(MKLDEXPORT) lib$(NAME).a > lib$(NAME)$(EXPSUFF)
!     $(COMPILER) $(LDFLAGS_NO_L) $(LDFLAGS_SL) -o $(shlib) lib$(NAME).a -Wl,-bE:lib$(NAME)$(EXPSUFF) $(SHLIB_LINK)
!     rm -f lib$(NAME).a
!     $(AR) $(AROPT) lib$(NAME).a $(shlib)

  endif # PORTNAME == aix

***************
*** 350,355 ****
--- 354,360 ----

  ifeq ($(enable_shared), yes)
  install-lib-shared: $(shlib)
+ ifneq ($(PORTNAME), aix)        # we don't install $(shlib) on AIX
      $(INSTALL_SHLIB) $< '$(DESTDIR)$(libdir)/$(shlib)'
  ifneq ($(PORTNAME), cygwin)
  ifneq ($(PORTNAME), win32)
***************
*** 365,370 ****
--- 370,376 ----
  endif
  endif # not win32
  endif # not cygwin
+ endif # not aix
  endif # enable_shared



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [COMMITTERS] pgsql: Sequences were not being shown due to
Next
From: Tom Lane
Date:
Subject: Re: [COMMITTERS] pgsql: Sequences were not being shown due to the use of lowercase 's'