Why does make_noname insert a SeqScan above sort/material node? - Mailing list pgsql-hackers

From Tom Lane
Subject Why does make_noname insert a SeqScan above sort/material node?
Date
Msg-id 6910.934850488@sss.pgh.pa.us
Whole thread Raw
Responses Re: [HACKERS] Why does make_noname insert a SeqScan above sort/material node?  (Bruce Momjian <maillist@candle.pha.pa.us>)
List pgsql-hackers
Does anyone know why make_noname (in createplan.c) insists on putting
a SeqScan plan node above the Sort or Material node it's generating?
As far as I can tell, it's a waste of cycles:

1. planner.c doesn't bother with a SeqScan above the Sorts it makes.
2. The executor's nodeSeqscan.c just redirects all its calls to the  outerPlan node, if it has an outerPlan.
3. Things seem to work fine without it ;-)

However, I'm not quite ready to commit this change without consultation.
Does anyone know what this was for?
        regards, tom lane


pgsql-hackers by date:

Previous
From: Hannu Krosing
Date:
Subject: Re: [HACKERS] Re: your mail
Next
From: Vadim Mikheev
Date:
Subject: Re: [HACKERS] Re: [CORE] Re: tomorrow