Re: [HACKERS] Mishandling of WCO constraints in direct foreign tablemodification - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [HACKERS] Mishandling of WCO constraints in direct foreign tablemodification
Date
Msg-id 68fd725a-e961-ccad-99df-74909f831452@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Mishandling of WCO constraints in direct foreign table modification  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2017/07/25 5:35, Robert Haas wrote:
> On Fri, Jul 21, 2017 at 6:21 AM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> I mean constraints derived from WITH CHECK OPTIONs specified for parent
>> views.  We use the words "WITH CHECK OPTION constraints" in comments in
>> nodeModifyTable.c, so the expression "CHECK OPTION constrains" doesn't sound
>> not that bad to me.  (I used "CHECK OPTION", not "WITH CHECK OPTION",
>> because we use "CHECK OPTION" a lot more in the documentation than "WITH
>> CHECK OPTION".)
> 
> Yeah, it seems OK to me, too; if the consensus is otherwise, we also
> have the option to change it later.
Agreed.

> Committed and back-patched as you
> had it, but I removed a spurious comma.

Thanks for that, Robert!  Thanks for reviewing, Horiguchi-san!

Best regards,
Etsuro Fujita




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] Change in "policy" on dump ordering?
Next
From: Peter Geoghegan
Date:
Subject: Re: LP_DEAD hinting and not holding on to a buffer pin on leaf page(Was: [HACKERS] [WIP] Zipfian distribution in pgbench)