Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section
Date
Msg-id 68a4435c-3990-419d-a68a-b33a7f9185ab@eisentraut.org
Whole thread Raw
In response to Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section  (Melanie Plageman <melanieplageman@gmail.com>)
List pgsql-hackers
On 07.01.25 18:31, Melanie Plageman wrote:
> On Tue, Jan 7, 2025 at 12:15 PM Melanie Plageman
> <melanieplageman@gmail.com> wrote:
>>
>> Cool, I've attached a patch to do this. I left a few of the GUCs under
>> Resource Consumption (like autovacuum_work_mem and
>> vacuum_buffer_usage_limit) where they are because it seemed
>> appropriate.
>>
>> This is my first docs patch that introduces new sections and such, so
>> I'm not sure I got the indentation 100% correct (I, of course, tried
>> to follow conventions).
> 
> Oh, one thing I forgot to say. Though I increased the indentation of
> some of the subsections that I moved, I didn't rewrap the lines
> because they were already not wrapped to 78. I can do this, but I
> can't tell from the existing docs what text width the paragraphs of
> text are supposed to be wrapped to.

For a patch that moves things around like this, I would leave everything 
as is and not rewrap.  That makes it easier to follow what's going on 
with "git diff -w", "git show -w" etc.

In .dir-locals.el, there is this configuration for Emacs:

  (nxml-mode . ((fill-column . 78)
                (indent-tabs-mode . nil)))

So that's one data point about what the line length should be.




pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: CREATE TABLE NOT VALID for check and foreign key
Next
From: Peter Eisentraut
Date:
Subject: Re: Virtual generated columns