Re: MSVC buildfarm critters are not running modules' TAP tests - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: MSVC buildfarm critters are not running modules' TAP tests
Date
Msg-id 688d32cf-19be-c8f0-f08b-fde25d15132e@2ndQuadrant.com
Whole thread Raw
In response to Re: MSVC buildfarm critters are not running modules' TAP tests  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: MSVC buildfarm critters are not running modules' TAP tests
List pgsql-hackers
On 9/8/19 5:59 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 9/8/19 12:07 PM, Tom Lane wrote:
>>> It looks to me like the reason is that src/tools/msvc/vcregress.pl's
>>> subroutine subdircheck isn't considering the possibility that
>>> subdirectories of src/test/modules contain TAP tests.  The
>>> same code is used for contrib, so several existing TAP tests
>>> are being missed there too.
>> Actually, I think vcregress.pl is OK, this is a gap in the buildfarm
>> client's coverage that will be fixed when I make a new release.
> Hm.  Changing the buildfarm script would be an alternative way to
> fix the issue so far as the buildfarm is concerned, but it doesn't
> seem like it provides any useful way for one to manually invoke
> the tests on Windows.  Or am I missing something about how that's
> usually done?
>
>             


The invocation is:


    vcregress.pl taptest [ PROVE_FLAGS=xxx ] directory


directory needs to be relative to $topdir, so something like:


    vcregress.pl taptest src/test/modules/test_misc


cheers


andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: msys2 vs pg_upgrade/test.sh
Next
From: Tom Lane
Date:
Subject: Re: MSVC buildfarm critters are not running modules' TAP tests