Re: Add missing PGDLLIMPORT markings - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Add missing PGDLLIMPORT markings
Date
Msg-id 68638ACC-3556-429E-93A0-189F73D0E274@yesql.se
Whole thread Raw
In response to Add missing PGDLLIMPORT markings  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Add missing PGDLLIMPORT markings
Re: Add missing PGDLLIMPORT markings
List pgsql-hackers
> On 9 Apr 2025, at 12:02, Peter Eisentraut <peter@eisentraut.org> wrote:

-extern const pg_be_sasl_mech pg_be_oauth_mech;
+extern PGDLLIMPORT const pg_be_sasl_mech pg_be_oauth_mech;
+1 on this.

> Btw., this new variable in memutils.h
>
>    extern dsa_area *area;
>
> could probably do with a less generic name?

Good point, unless objected to I'll apply the attached renaming which then also
contain the PGDLLIMPORT addition.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Junwang Zhao
Date:
Subject: Re: Remove unnecessary static type qualifiers
Next
From: Tender Wang
Date:
Subject: Consistently use macro HeapTupleIsValid to check the validity of tuples in tablecmds.c