Re: [PATCH] Add inline comments to the pg_hba_file_rules view - Mailing list pgsql-hackers

From Jim Jones
Subject Re: [PATCH] Add inline comments to the pg_hba_file_rules view
Date
Msg-id 67fbaedc-6983-1f06-822d-6db487cb505a@uni-muenster.de
Whole thread Raw
In response to Re: [PATCH] Add inline comments to the pg_hba_file_rules view  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Hi Daniel

On 27.09.23 10:21, Daniel Gustafsson wrote:
> An annotation syntax specifically for this would address my concern, 
> but the
> argument that pg_hba (and related code) is border-line too complicated as it is
> does hold some water.  Complexity in code can lead to bugs, but complexity in
> syntax can lead to misconfigurations or unintentional infosec leaks which is
> usually more problematic.
Yeah, that's why the possibility to use the normal comments for this 
feature seemed at first so appealing :)
> I would propose to not worry about code and instead just discuss a potential
> new format for annotations, and only implement parsing and handling once
> something has been agreed upon.  This should be in a new thread however to
> ensure visibility, since it's beyond the subject of this thread.

Sounds good! I will open a new thread as soon as I get back home, so 
that we can collect some ideas.

Thanks

Jim




pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: [PoC] pg_upgrade: allow to upgrade publisher node
Next
From: Heikki Linnakangas
Date:
Subject: Re: Latches vs lwlock contention