Re: Use of backup_label not noted in log - Mailing list pgsql-hackers

From Laurenz Albe
Subject Re: Use of backup_label not noted in log
Date
Msg-id 67c6cea866ee7aeb324008341a8c697151146a9d.camel@cybertec.at
Whole thread Raw
In response to Re: Use of backup_label not noted in log  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Use of backup_label not noted in log
Re: Use of backup_label not noted in log
Re: Use of backup_label not noted in log
List pgsql-hackers
I can accept that adding log messages to back branches is ok.
Perhaps I am too nervous about things like that, because as an extension
developer I have been bitten too often by ABI breaks in minor releases
in the past.

On Mon, 2023-11-20 at 17:30 +0900, Michael Paquier wrote:
> +       if (ControlFile->backupStartPoint != InvalidXLogRecPtr)
> +           ereport(LOG,
> +                   (errmsg("continuing to start from base backup with redo LSN %X/%X",
> +                           LSN_FORMAT_ARGS(ControlFile->backupStartPoint))));
>
> "Continuing to start" sounds a bit weird to me, though, considering
> that there are a few LOGs that say "starting" when there is a signal
> file, but I don't have a better idea on top of my mind.  So that
> sounds OK here.

We can only reach that message in recovery or standby mode, right?
So why not write "continuing to recover from base backup"?


If we add a message for starting with "backup_label", shouldn't
we also add a corresponding message for starting from a checkpoint
found in the control file?  If you see that in a problem report,
you immediately know what is going on.

Yours,
Laurenz Albe



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: should check collations when creating partitioned index
Next
From: Tomas Vondra
Date:
Subject: Re: Inquiry on Generating Bitmaps from Filter Conditions in Index Scans