Re: Coding style point: "const" in function parameter declarations - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Coding style point: "const" in function parameter declarations
Date
Msg-id 6767.1308787280@sss.pgh.pa.us
Whole thread Raw
In response to Re: Coding style point: "const" in function parameter declarations  (Greg Stark <stark@mit.edu>)
List pgsql-hackers
Greg Stark <stark@mit.edu> writes:
> On Wed, Jun 22, 2011 at 5:41 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> If we were thinking of moving in that direction, I would argue that
>> we should get rid of typedef'd pointers altogether, ie, change
>> "Relation" to be a typedef for the struct and write "Relation *rel"
>> not "Relation rel".

> Hm. I have to say the single most confusing thing about the Postgres
> source that took me a *long* time to get over was remembering that
> some of the typedefs were already pointers and some weren't.

Yeah, the lack of consistency about that is annoying.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: Coding style point: "const" in function parameter declarations
Next
From: Peter Geoghegan
Date:
Subject: Re: Coding style point: "const" in function parameter declarations