Re: pg_upgrade --clone error checking - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pg_upgrade --clone error checking
Date
Msg-id 66bb3489-7bd7-9157-605d-0d15dc315551@2ndquadrant.com
Whole thread Raw
In response to Re: pg_upgrade --clone error checking  (Jeff Janes <jeff.janes@gmail.com>)
Responses Re: pg_upgrade --clone error checking  (Jeff Janes <jeff.janes@gmail.com>)
List pgsql-hackers
On 2019-05-02 20:03, Jeff Janes wrote:
> It looks like it was designed for early checking, it just wasn't placed
> early enough.  So changing it is pretty easy, as check_file_clone does
> not need to be invented, and there is no additional code duplication
> over what was already there.
> 
> This patch moves the checking to near the beginning.

I think the reason it was ordered that way is that it wants to do all
the checks of the old cluster before doing any checks touching the new
cluster.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Rafia Sabih
Date:
Subject: Re: [PATCH v1] Show whether tables are logged in \dt+
Next
From: Amit Kapila
Date:
Subject: Re: Unhappy about API changes in the no-fsm-for-small-rels patch