Re: ExplainProperty* and units - Mailing list pgsql-hackers

From Tom Lane
Subject Re: ExplainProperty* and units
Date
Msg-id 6643.1521049192@sss.pgh.pa.us
Whole thread Raw
In response to Re: ExplainProperty* and units  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2018-03-14 13:32:10 -0400, Tom Lane wrote:
>> Andres Freund <andres@anarazel.de> writes:
>>> Only thing I wonder is if we shouldn't just *remove*
>>> ExplainPropertyLong and make ExplainPropertyInteger accept 64bits of
>>> input - the effort of passing and printing a 64bit integer will never be
>>> relevant for explain.

>> -0.5 ... everywhere else, we mean "int32" when we say "int", and I don't
>> think it's worth the potential confusion to do it differently here.

> So ExplainPropertyInt{32,64}?

I was thinking more of replacing ExplainPropertyLong with
ExplainPropertyInt64 and leaving ExplainPropertyInteger as-is.
Don't see the value in renaming that one just to rename it.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ExplainProperty* and units
Next
From: Peter Eisentraut
Date:
Subject: Re: INOUT parameters in procedures