Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Date
Msg-id 6596.1214343290@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout  (daveg <daveg@sonic.net>)
Responses Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout  (daveg <daveg@sonic.net>)
List pgsql-patches
daveg <daveg@sonic.net> writes:
> lock-timeout sets statement_timeout to a small value while locks are being
> taken on all the tables. Then it resets it to default. So it could reset it
> to whatever the new default is.

"reset to default" is *surely* not the right behavior; resetting to the
setting that had been in effect might be a bit sane.  But the whole
design sounds pretty broken to start with.  The timer management code
already understands the concept of scheduling the interrupt for the
nearest of a couple of potentially active timeouts.  ISTM any patch
intended to add a feature like this ought to extend that logic rather
than hack around changing the values of global variables.

            regards, tom lane

pgsql-patches by date:

Previous
From: daveg
Date:
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Next
From: daveg
Date:
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout