Re: error in compilation! - Mailing list pgsql-hackers

From Gurjeet Singh
Subject Re: error in compilation!
Date
Msg-id 65937bea0605271916u3ae68733wf9af175e86ac38e7@mail.gmail.com
Whole thread Raw
In response to Re: error in compilation!  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Confirmation: The patch rollback in src/pl/plpgsql/src/gram.y resolved
the issue.

On 5/28/06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> I wrote:
> > Currently looking through the rest of the patch.  I'm wondering
> > about appendStringLiteral: maybe we should kill that entirely
> > in favor of using PQescapeStringConn?  It's not nearly bright
> > enough about encoding for instance (and it *will* be used in
> > client-only encodings).
>
> We could make an appendStringLiteralConn, which would do this correctly
> for most of the utility programs.  However there's a problem for
> pg_restore: it doesn't necessarily have a PGconn at all.  (Consider
> the case of pg_restore producing text output.)
>
> It seems that the alternatives are to export PQescapeStringInternal
> from libpq, or to duplicate its functionality in appendStringLiteral.
> Don't much like either, but perhaps the second is less bad.  Any
> opinions?
>
>                         regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match
>


pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: osprey buildfarm member has been failing for a long while
Next
From: Bruce Momjian
Date:
Subject: Re: error in compilation!