Re: [subxacts] Fixing TODO items - Mailing list pgsql-patches

From Tom Lane
Subject Re: [subxacts] Fixing TODO items
Date
Msg-id 656.1090949521@sss.pgh.pa.us
Whole thread Raw
In response to [subxacts] Fixing TODO items  (Alvaro Herrera <alvherre@dcc.uchile.cl>)
Responses Re: [subxacts] Fixing TODO items
Re: [subxacts] Fixing TODO items
List pgsql-patches
Alvaro Herrera <alvherre@dcc.uchile.cl> writes:
> There are some likely controversial changes; the Xid caches, in the
> first place.

No kidding ;-)

Do you have any theoretical or practical evidence for the usefulness of
the negxids cache?  Seems to me the shared memory space would be better
spent on allowing deeper nesting of the running-subxids list.  Also,
what happened to marking whether the running-subxids list has
overflowed?  If none of them have then there's no need to wonder whether
we have a still-running subxact.

The apparent lack of any locking on these data structures seems wrong
too.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [subxacts] Fixing TODO items
Next
From: Christopher Kings-Lynne
Date:
Subject: USING INDEX TABLESPACE