Re: [COMMITTERS] pgsql: Use static inline functions for float <-> Datum conversions. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [COMMITTERS] pgsql: Use static inline functions for float <-> Datum conversions.
Date
Msg-id 6493.1472665698@sss.pgh.pa.us
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Use static inline functions for float <-> Datum conversions.  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 08/31/2016 08:27 PM, Tom Lane wrote:
>> We had a bunch of similar problems in the recent work on exact degree trig
>> functions, and eventually found that storing values into volatile float8
>> variables was the most reliable way to force rounding to the expected
>> storage width.  I propose to replace the above hack with declaring
>> newelemorder as volatile, and see if that makes things better.

> Sounds reasonable. None of this is supposed to be necessary, we're just 
> working around broken compilers, so whatever works.

> I'll prepare a patch for that tomorrow, unless you're on it already.

On it already.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: ICU integration
Next
From: Tom Lane
Date:
Subject: Re: pg_sequence catalog