Re: Corner-case bug in pg_rewind - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Corner-case bug in pg_rewind
Date
Msg-id 6489f34a-0294-78b7-389b-37044afbe18f@iki.fi
Whole thread Raw
In response to Re: Corner-case bug in pg_rewind  (Ian Barwick <ian.barwick@2ndquadrant.com>)
Responses Re: Corner-case bug in pg_rewind
Re: Corner-case bug in pg_rewind
List pgsql-hackers
On 02/12/2020 15:26, Ian Barwick wrote:
> On 02/12/2020 20:13, Heikki Linnakangas wrote:
>> Attached are two patches. The first patch is your original patch, unmodified
>> (except for a cosmetic rename of the test file). The second patch builds on
>> that, demonstrating and fixing the issue I mentioned. It took me a while to
>> create a repro for it, it's easily masked by incidental full-page writes or
>> because rows created by XIDs that are not marked as committed on the other
>> timeline are invisible, but succeeded at last.
> 
> Aha, many thanks. I wasn't entirely sure what I was looking for there and
> recently haven't had the time or energy to dig any further.

Ok, pushed and backpatched this now.

Thanks!

- Heikki



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Single transaction in the tablesync worker?
Next
From: Pavel Borisov
Date:
Subject: Re: Corner-case bug in pg_rewind