Re: pg_upgrade fails to detect unsupported arrays and ranges - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_upgrade fails to detect unsupported arrays and ranges
Date
Msg-id 63DE9A1C-5F59-47AF-90C9-26A7EF9897B3@yesql.se
Whole thread Raw
In response to Re: pg_upgrade fails to detect unsupported arrays and ranges  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pg_upgrade fails to detect unsupported arrays and ranges  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 10 Nov 2019, at 22:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 10 Nov 2019, at 20:07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> (Note: this patch is shown with --ignore-space-change
>>> to make it more reviewable, but I did re-pgindent the code.)  Then
>>> 0002 actually adds the array and range cases.
>
>> Was the source pgindented, but not committed, before generating the patches?  I
>> fail to apply them on master (or REL_12_STABLE) on what seems to be only
>> whitespace changes.
>
> Hm, I suppose it might be hard to apply the combination of the patches
> (maybe something involving patch -l would work).  For simplicity, here's
> the complete patch for HEAD.  I fixed a missing schema qualification.

Applies, builds clean and passes light testing.  I can see the appeal of
including it before the wrap, even though I personally would've held off.

cheers ./daniel


pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges
Next
From: Tom Lane
Date:
Subject: Re: pg_upgrade fails to detect unsupported arrays and ranges