Re: doc: create table improvements - Mailing list pgsql-hackers

From Chao Li
Subject Re: doc: create table improvements
Date
Msg-id 63CD263B-E821-43BB-9B22-48C48326D663@gmail.com
Whole thread Raw
In response to Re: doc: create table improvements  (Laurenz Albe <laurenz.albe@cybertec.at>)
Responses Re: doc: create table improvements
List pgsql-hackers

> On Oct 23, 2025, at 12:43, Laurenz Albe <laurenz.albe@cybertec.at> wrote:
>
> On Mon, 2025-10-20 at 07:41 -0400, David G. Johnston wrote:
>> I question whether “parameter” is even the correct class to assign here
>> and so would rather avoid the issue by not assigning a class.
>
> Right.  I have removed the vestiges from my failed attempt to improve
> the "parameter" decorations.
>
>> “If none is specified, the data will be persistent” would be better
>> written “If unspecified the data will be persistent” (or, “if not specified…”)
>
> I decided to use the trusted phrasing "by default".
>
>> Everything else looks good.
>
> Patch attached; if it is fine with you, I'll mark it "ready for committer".
>
> Yours,
> Laurenz Albe
> <v4-0001-Unclutter-CREATE-TABLE-synopsis.patch>

Overall the change looks good to me. I have only one comment about the naming of “oversize_storage”. Why not just
“storage_parameters”or similar that sounds more straightforward? 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: "Euler Taveira"
Date:
Subject: Re: Improve logical replication usability when tables lack primary keys
Next
From: "cca5507"
Date:
Subject: Re: [PATCH] Add pg_lfind8_nonzero()