Re: [PATCH] Add pg_lfind8_nonzero() - Mailing list pgsql-hackers

From cca5507
Subject Re: [PATCH] Add pg_lfind8_nonzero()
Date
Msg-id tencent_33BE9451990CBCED8313BB8150EEC290DA07@qq.com
Whole thread Raw
In response to Re: [PATCH] Add pg_lfind8_nonzero()  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

Thank you for your reply!

> Is code like this ever actually relevant for performance? In cases where the
> compiler can't also optimize the code? Unless it is a legitimate bottleneck,
> adding more complicated code to optimize the case doesn't make sense.

I just think the patch isn't that complicated.

> The benchmark really should show performance benefits in at least somewhat
> realistic cases (i.e. real users of the functions, even if the workload is a
> bit more extreme than it'd be most of the time).

Yeah, this makes sense to me. Maybe I need to think more on it.

--
Regards,
ChangAo Chen

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: doc: create table improvements
Next
From: jian he
Date:
Subject: Re: create table like including storage parameter