Re: Dependency to logging in jsonapi.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Dependency to logging in jsonapi.c
Date
Msg-id 632491.1625094031@sss.pgh.pa.us
Whole thread Raw
In response to Re: Dependency to logging in jsonapi.c  (Michael Paquier <michael@paquier.xyz>)
Responses Re: Dependency to logging in jsonapi.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Wed, Jun 30, 2021 at 03:47:19PM +0000, Jacob Champion wrote:
>> But until/unless that is changed, an #ifndef seems like a good way to
>> prevent issues for the current code.

> Sounds sensible to do that as well for 14 before the release.  Any
> thoughts about that?

If this code were new in v14, I'd be +1, but it looks like it was
there in 13 too.  So maybe there's somebody external depending on
it, which would make it a bit unfriendly to remove it post-beta.
Let's just add the #ifndef in HEAD.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jacob Champion
Date:
Subject: Re: Preventing abort() and exit() calls in libpq
Next
From: Tom Lane
Date:
Subject: Re: Small clean up in nodeAgg.c