Re: [PATCH] Add pretty-printed XML output option - Mailing list pgsql-hackers

From Jim Jones
Subject Re: [PATCH] Add pretty-printed XML output option
Date
Msg-id 62dffe3b-7eb0-2f36-b874-839f6864126d@uni-muenster.de
Whole thread Raw
In response to Re: [PATCH] Add pretty-printed XML output option  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: [PATCH] Add pretty-printed XML output option
List pgsql-hackers
On 13.02.23 02:15, Peter Smith wrote:
Something is misbehaving.

Using the latest HEAD, and before applying the v6 patch, 'make check'
is working OK.

But after applying the v6 patch, some XML regression tests are failing
because the DETAIL part of the message indicating the wrong syntax
position is not getting displayed. Not only for your new tests -- but
for other XML tests too.

Yes, I noticed it yesterday ... and I'm not sure how to solve it. It seems that in the system is returning a different error message in the FreeBSD patch tester, which is causing a regression test in this particular OS to fail.


diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/xml.out /tmp/cirrus-ci-build/build/testrun/regress/regress/results/xml.out
--- /tmp/cirrus-ci-build/src/test/regress/expected/xml.out	2023-02-12 09:02:57.077569000 +0000
+++ /tmp/cirrus-ci-build/build/testrun/regress/regress/results/xml.out	2023-02-12 09:05:45.148100000 +0000
@@ -1695,10 +1695,7 @@ -- XML format: empty string SELECT xmlformat(''); ERROR:  invalid XML document
-DETAIL:  line 1: switching encoding : no input
-
-^
-line 1: Document is empty
+DETAIL:  line 1: Document is empty  ^ -- XML format: invalid string (whitespaces)


Does anyone know if there is anything I can do to make the error messages be consistent among different OS?

pgsql-hackers by date:

Previous
From: Jelte Fennema
Date:
Subject: Making CopyFromStateData not internal anymore
Next
From: Andrew Dunstan
Date:
Subject: Re: run pgindent on a regular basis / scripted manner