Re: pkg-config files for libpq and ecpg - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pkg-config files for libpq and ecpg
Date
Msg-id 6262.1358293995@sss.pgh.pa.us
Whole thread Raw
In response to pkg-config files for libpq and ecpg  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: pkg-config files for libpq and ecpg
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> I'll take another stab at providing pkg-config files for the client-side
> libraries.

This bit:

> +    echo 'Libs.private: $(filter-out $(PKG_CONFIG_REQUIRES_PRIVATE:lib%=-l%),$(filter-out -L..%, $(SHLIB_LINK)))'
>>$@

appears to assume that SHLIB_LINK contains nothing except -L and -l
switches.  I don't think I trust that a whole lot --- in fact, it
looks guaranteed to fail on HPUX because of -print-libgcc-file-name.
There might be other platform-specific bogosity on other platforms;
PTHREAD_LIBS seems like a likely source for instance.

Another point is that -L switches used at build time might not have much
to do with the environment a .pc file would be used in later.  I see
that you're dropping relative -L paths, which is good as far as it
goes, but I wonder whether it goes far enough.

Perhaps the first step should be to filter in -l%, rather than
filter out -L% ?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_ctl idempotent option
Next
From: Josh Hansen
Date:
Subject: Patch: log level change in gistsplit.c