RE: Use list_delete_cell instead in some places - Mailing list pgsql-hackers

From Hou, Zhijie
Subject RE: Use list_delete_cell instead in some places
Date
Msg-id 6197b35337334dd4ba3a8a0a53ec5d59@G08CNEXMBPEKD05.g08.fujitsu.local
Whole thread Raw
List pgsql-hackers
> I found some code path use list_delete_ptr while the loop of foreach() is
> iterating.
>
> List_delete_ptr seems search the list again to find the target cell and
> delete it.
> >    foreach(cell, list)
> >    {
> >        if (lfirst(cell) == datum)
> >            return list_delete_cell(list, cell);
> >    }
>
>
> If we already get the cell in foreach loop, I think we can use
> list_delete_cell to avoid searching the list again.
>
> Please see the attachment for the patch.

I have added it to commitfest.
https://commitfest.postgresql.org/30/2761/

Best regards.





pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication
Next
From: Luc Vlaming
Date:
Subject: allow partial union-all and improve parallel subquery costing