Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion - Mailing list pgsql-hackers

From katouknl
Subject Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion
Date
Msg-id 617cc933f32d460c9a4f1e12e116de03@oss.nttdata.com
Whole thread Raw
In response to Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion  (Suraj Khamkar <khamkarsuraj.b@gmail.com>)
Responses Re: [PATCH] Added TRANSFORM FOR for COMMENT tab completion  (Shinya Kato <Shinya11.Kato@oss.nttdata.com>)
List pgsql-hackers
Hi,

Thank you for the review.

I wasn't quite sure where to start counting the characters,
but I used pgindent to properly format it, so hopefully everything is 
okay.
Also, I sorted them in alphabetical order just to make it look prettier.
>     * The below change crosses the 80-character limit in a line. Please
> maintain the same.
> -   "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "ROLE");
> +   "LARGE OBJECT", "TABLESPACE", "TEXT SEARCH", "TRANSFORM FOR",
> "ROLE");

I made sure there is no whitespaces this time.
>     * There are trailing whitespaces after
> COMPLETE_WITH_QUERY(Query_for_list_of_languages);.
> Remove these extra whitespaces.
> surajkhamkar@localhost:tab_comment$ git apply
> fix_tab_complete_comment.patch
> fix_tab_complete_comment.patch:38: trailing whitespace.
> COMPLETE_WITH_QUERY(Query_for_list_of_languages);
> warning: 1 line adds whitespace errors.

Best wishes,
Ken Kato
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: strange case of "if ((a & b))"
Next
From: Antonin Houska
Date:
Subject: Re: storing an explicit nonce