Re: [RFC] building postgres with meson -v7 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [RFC] building postgres with meson -v7
Date
Msg-id 616c6873-83b5-85c0-93cb-548977c39c60@enterprisedb.com
Whole thread Raw
In response to Re: [RFC] building postgres with meson -v7  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On 09.03.22 17:44, Andres Freund wrote:
>> v6-0009-prereq-make-unicode-targets-work-in-vpath-builds.patch.gz
>>
>> Another directory issue
> I think it's a tad different, in that it's fixing something that's currently
> broken in VPATH builds.

Ok, I took another look at this.

-override CPPFLAGS := -DFRONTEND $(CPPFLAGS)
+override CPPFLAGS := -DFRONTEND 
-I$(abs_top_builddir)/src/common/unicode $(CPPFLAGS)

This could just be

-I.

-   $(PERL) generate-unicode_norm_table.pl
+   $(PERL) $< $(CURDIR)

I didn't detect a need for the additional directory argument.  (So the 
changes in generate-unicode_norm_table.pl are also apparently not 
necessary.)  Maybe this is something that will become useful later, in 
which case it should be split out from this patch.

The rest of this patch looks ok.




pgsql-hackers by date:

Previous
From: Mark Dilger
Date:
Subject: Re: role self-revocation
Next
From: Dmitry Dolgov
Date:
Subject: Re: pg_stat_statements and "IN" conditions