Re: Stats Collector Won't Start - Mailing list pgsql-general

From Chris Browne
Subject Re: Stats Collector Won't Start
Date
Msg-id 60u0205js9.fsf@dba2.int.libertyrms.com
Whole thread Raw
In response to Stats Collector Won't Start  (Brad Nicholson <bnichols@ca.afilias.info>)
Responses Re: Stats Collector Won't Start  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-general
tgl@sss.pgh.pa.us (Tom Lane) writes:
> Chris Browne <cbbrowne@acm.org> writes:
>> Is there a more elegant way of setting the requested port to 0 than my
>> 2-liner?
>
> What I'm tempted to do is add this to pg_getaddrinfo_all (in
> src/backend/libpq/ip.c):
>
>   {
>       /* not all versions of getaddrinfo() zero *result on failure */
>       *result = NULL;
>
> + #ifdef _AIX
> +    /* it seems AIX's getaddrinfo doesn't reliably zero sin_port */
> +    if (servname == NULL)
> +        servname = "0";
> + #endif
> +
>   #ifdef HAVE_UNIX_SOCKETS
>       if (hintp->ai_family == AF_UNIX)
>           return getaddrinfo_unix(servname, hintp, result);
>
> Want to try that?

That seems to work fine, too.  And that seems somewhat more
portable/elegant/something.
--
let name="cbbrowne" and tld="cbbrowne.com" in String.concat "@" [name;tld];;
http://linuxfinances.info/info/internet.html
"Survival in a world of words is best made, if at all, through clever
appeal to ambiguity." -- Robert Bolt

pgsql-general by date:

Previous
From: Tom Lane
Date:
Subject: Re: Stats Collector Won't Start
Next
From: Tom Lane
Date:
Subject: Re: Stats Collector Won't Start