Re: Lessons from commit fest - Mailing list pgsql-hackers

From Chris Browne
Subject Re: Lessons from commit fest
Date
Msg-id 60k5ixu4bx.fsf@dba2.int.libertyrms.com
Whole thread Raw
In response to Re: Lessons from commit fest  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Lessons from commit fest
List pgsql-hackers
bruce@momjian.us (Bruce Momjian) writes:
> Magnus Hagander wrote:
>> > And I think adopting surrounding naming, commeting, coding conventions
>> > should come naturally as it can aide in copy-pasting too :)
>> 
>> I think pg_indent has to be made a lot more portable and easy to use
>> before that can happen :-) I've run it once or twice on linux machines,
>> and it comes out with huge changes compared to what Bruce gets on his
>> machine. Other times, it doesn't :-) So yeah, it could be that it just
>> needs to be made easier to use, because I may certainly have done
>> something wrong.
>
> Agreed, pgindent is too cumbersome to require patch submitters to use. 
> One idea would be to allow C files to be emailed and the indented
> version automatically returned via email.

Would it be a terrible idea to...

- Draw the indent code from NetBSD into src/tools/pgindent
- Build it _in place_ inside the code tree (e.g. - don't assume  it will get installed in /usr/local/bin)
- Thus have the ability to run it in place?
-- 
let name="cbbrowne" and tld="linuxfinances.info" in name ^ "@" ^ tld;;
http://cbbrowne.com/info/lisp.html
"It worked about as well as sticking a blender in the middle of a lime
plantation and hoping they'll make margaritas out of themselves."
-- Frederick J. Polsky v1.0


pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: pg_terminate_backend() issues
Next
From: Bruce Momjian
Date:
Subject: Re: [PATCHES] Avahi support for Postgresql