> Actually, what you are doing is incorrect because we could miss some
> ERRORs for example if a base backup was incorrect if come files were > present in pg_twophase?
Yes, you are right, base backup with incorrect files would be a problem.
> It's not really true that what you are changing here has no > interaction with the beginning of recovery, the other thread is about > the fact that reading the 2PC files from disk when !reachedConsistency > is a bad concept that we should avoid, impacting the assumption the > code path you are changing here relies on. At the end, it may be > possible that we're able to remove this check entirely..
Is there any recent discussion or plan regarding this? I noticed that in the latest code branch, 2PC data on disk is still being restored when !reachedConsistency. If there are any updates or discussions,I would greatly appreciate it if you could let me know
