Re: InsertXLogFile in pg_resetxlog - Mailing list pgsql-hackers

From Tom Lane
Subject Re: InsertXLogFile in pg_resetxlog
Date
Msg-id 6086.1146497678@sss.pgh.pa.us
Whole thread Raw
In response to InsertXLogFile in pg_resetxlog  (Martijn van Oosterhout <kleptog@svana.org>)
Responses Re: InsertXLogFile in pg_resetxlog  ("Jonah H. Harris" <jonah.harris@gmail.com>)
List pgsql-hackers
Martijn van Oosterhout <kleptog@svana.org> writes:
> May I propose the entire part of that function after the comment /* the
> list is empty. */ be replaced with something like the following (or
> whatever idiom people prefer for singly-linked lists):

This certainly looks like it was written by someone who'd just learned
about lists yesterday :-(.  I wonder how many other problems there are
in that resetxlog patch?  I didn't bother to look at it at all myself.
Anyone have time to review it?

http://archives.postgresql.org/pgsql-committers/2006-04/msg00299.php
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Is a SERIAL column a "black box", or not?
Next
From: "Jonah H. Harris"
Date:
Subject: Re: InsertXLogFile in pg_resetxlog