Re: Review: listagg aggregate - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Review: listagg aggregate
Date
Msg-id 603c8f071001280802l73c359bdv691f42a41c1bf451@mail.gmail.com
Whole thread Raw
In response to Re: Review: listagg aggregate  (Takahiro Itagaki <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: Review: listagg aggregate  (Pavel Stehule <pavel.stehule@gmail.com>)
List pgsql-hackers
On Wed, Jan 27, 2010 at 9:47 PM, Takahiro Itagaki
<itagaki.takahiro@oss.ntt.co.jp> wrote:
> * Do we need better names for string_agg1_transfn and string_agg2_transfn?
>  They are almost "internal names", but we could have more
>  like string_agg_with_sep_transfn.

Surely the names of the transition and final functions should match
the name of the aggregate.  But if there's a proposal on the table to
call this string_app_with_sep() instead of just string_agg(), +1 from
me.

...Robert


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Review: listagg aggregate
Next
From: Tim Bunce
Date:
Subject: Re: Add on_perl_init and proper destruction to plperl [PATCH]