Re: ProcessUtility_hook - Mailing list pgsql-hackers

From Robert Haas
Subject Re: ProcessUtility_hook
Date
Msg-id 603c8f070912091815t690b37baq8512b9a48c6a1b86@mail.gmail.com
Whole thread Raw
In response to Re: ProcessUtility_hook  (Itagaki Takahiro <itagaki.takahiro@oss.ntt.co.jp>)
Responses Re: ProcessUtility_hook
List pgsql-hackers
Why does this patch #ifdef out the _PG_fini code in pg_stat_statements?

Where you check for INSERT, UPDATE, and DELETE return codes in
pgss_ProcessUtility, I think this deserves a comment explaining that
these could occur as a result of EXECUTE.  It wasn't obvious to me,
anyway.

It seems to me that the current hook placement does not address this complaint

>> 1. The placement of the hook.  Why is it three lines down in
>> ProcessUtility?  It's probably reasonable to have the Assert first,
>> but I don't see why the hook function should have the ability to
>> editorialize on the behavior of everything about ProcessUtility
>> *except* the read-only-xact check.

...Robert


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: bug: fuzzystrmatch levenshtein is wrong
Next
From: Takahiro Itagaki
Date:
Subject: Re: ProcessUtility_hook