Re: Issues for named/mixed function notation patch - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Issues for named/mixed function notation patch
Date
Msg-id 603c8f070909271035y1757a034g9b47221203434cf8@mail.gmail.com
Whole thread Raw
In response to Re: Issues for named/mixed function notation patch  (Pavel Stehule <pavel.stehule@gmail.com>)
Responses Re: Issues for named/mixed function notation patch
List pgsql-hackers
On Sun, Sep 27, 2009 at 12:37 AM, Pavel Stehule <pavel.stehule@gmail.com> wrote:
>> "However, a named variadic argument can only be called the way shown in
>> the example above. The VARIADIC keyword must not be specified and a
>> variadic notation of all arguments is not supported. To use variadic
>> argument lists you must use positional notation instead."
>>
>> What is the intended behavior? I think we should always require VARIADIC
>> to be specified regardless of using named notation.
>>
>
> maybe we could to support variadic named parameters in future - then
> using VARIADIC keyword should be necessary - like
>
> foo(10 AS p1, 20 AS p1, 30 AS p3) is equalent of
> foo(VARIADIC ARRAY[10,20] AS p1, 30 AS p3)

Pavel,

This doesn't make sense to me, FWIW.  I don't think we should allow
parameters to be specified more than once.  It's hard for me to
imagine how that could be useful.

>> I'm still reviewing the code.

Jeff,

When will you be able to post this review?

Thanks,

...Robert


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: SELECT ... FOR UPDATE [WAIT integer | NOWAIT] for 8.5
Next
From: Pavel Stehule
Date:
Subject: Re: Issues for named/mixed function notation patch