Re: updated join removal patch - Mailing list pgsql-hackers

From Robert Haas
Subject Re: updated join removal patch
Date
Msg-id 603c8f070909152000h49187b90va14fb6f90efc2f3e@mail.gmail.com
Whole thread Raw
In response to Re: updated join removal patch  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Sep 15, 2009 at 10:25 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Sep 15, 2009 at 10:10 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>>> * I'm not sure about this, because surely you would have tested it,
>>> but isn't it looking at the wrong side of the join clauses?  I thought
>>> the idea is to prove the nullable (inner) side of the join unique.
>>
>> Grr.  I think it's more broken than that.  Wow, this is really embarassing.
>
> Well, you're definitely right that it's looking at the wrong side of
> the join clauses.  Still trying to figure out if there is another bug,
> too.

It looks to me like relation_is_distinct_for() is also horribly broken
in my previous version.  I think the attached is how it is supposed to
work.

...Robert

Attachment

pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: Streaming Replication patch for CommitFest 2009-09
Next
From: Jeff Janes
Date:
Subject: Re: Bulk Inserts