Re: TODO items for window functions - Mailing list pgsql-hackers

From Robert Haas
Subject Re: TODO items for window functions
Date
Msg-id 603c8f070901010542o4bdc29c8if298f13d5e3e8080@mail.gmail.com
Whole thread Raw
In response to Re: TODO items for window functions  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: TODO items for window functions  (Bruce Momjian <bruce@momjian.us>)
Re: TODO items for window functions  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
> I am not thrilled about inventing a new column for this, but how about
> a display like so:
>
> regression=# \df nth_value
>                        List of functions
>   Schema   |   Name    | Result data type |       Argument data types
> ------------+-----------+------------------+---------------------------------
>  pg_catalog | nth_value | anyelement       | anyelement, integer OVER window
>
> or some other addition that only shows up when needed.

I think this whole idea is a bad one.  In the current release, you can do

DROP FUNCTION Name ( Argument data types )

...and it will work.  Maybe you will say that no one is doing this via
a script (which I wouldn't bet on, but it's possible) but I'm sure
people are doing it via cut and paste, because I have done exactly
this thing.  Any of the various proposals for hacking up Argument data
types will make this no longer true, and somebody will get confused.
I think you should bite the bullet and add a "type" column (f for
regular function and w for window?  could there be others in the
future?).

...Robert


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: TODO items for window functions
Next
From: Simon Riggs
Date:
Subject: Re: lazy_truncate_heap()