Re: Updated posix fadvise patch v19 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Updated posix fadvise patch v19
Date
Msg-id 603c8f070811180607g121924bcnc8ce10c465575c6@mail.gmail.com
Whole thread Raw
In response to Re: Updated posix fadvise patch v19  (Gregory Stark <stark@enterprisedb.com>)
Responses Re: Updated posix fadvise patch v19  (Gregory Stark <stark@enterprisedb.com>)
List pgsql-hackers
> For the FIXMEs I don't have any problem leaving them in place. They're
> warnings to future coders working in the same area of what they may have to do
> to make the code more general.

That's fine with me.  I think it's fine to document possibilities for
future development, but sometimes it's hard to tell between which such
things the patch author intends to be committed and which he or she
intends to fix before commit.  Maybe FIXME is just a noise word,
though: there are other places in the code where we document things
that might be related or need to be changed without using that word.
I don't care very much, though.

Looking forward to v20.

...Robert


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: TABLE command
Next
From: "Pavel Stehule"
Date:
Subject: is any reason why only one columns subselect are allowed in array()?