Re: BufferAccessStrategy for bulk insert - Mailing list pgsql-hackers

From Robert Haas
Subject Re: BufferAccessStrategy for bulk insert
Date
Msg-id 603c8f070810261737o6aea3d54h278060f641f988f9@mail.gmail.com
Whole thread Raw
In response to Re: BufferAccessStrategy for bulk insert  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: BufferAccessStrategy for bulk insert
List pgsql-hackers
> Seems sane to me.  I don't see the point of the HEAP_INSERT_BULK flag
> bit --- providing or not providing bistate would cover that, and if
> you have a bit as well then you have to define what the inconsistent
> combinations mean.  I concur with making all-zeroes be the typical
> state of the flag bits, too.

Thanks for the design review.  I had thought to make the inconsistent
combinations fail an assertion, but I'm just as happy to leave it out
altogether.

> FWIW, we generally declare bitmask flag variables as int, unless
> there's some really good reason to do otherwise.

OK, thanks for the tip.

...Robert


pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: array_agg and array_accum (patch)
Next
From: Tom Lane
Date:
Subject: WIP patch: convert SQL-language functions to return tuplestores