Re: remove ATTRIBUTE_FIXED_PART_SIZE - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: remove ATTRIBUTE_FIXED_PART_SIZE
Date
Msg-id 601c8f64-6be6-f31a-688a-6720b56abf55@2ndquadrant.com
Whole thread Raw
In response to Re: remove ATTRIBUTE_FIXED_PART_SIZE  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: remove ATTRIBUTE_FIXED_PART_SIZE
List pgsql-hackers
On 20/08/2018 15:14, Tom Lane wrote:
> I agree this is all moot as long as there's no pad bytes.  What I'm
> trying to figure out is if we need to put in place some provisions
> to prevent there from being pad bytes at the end of any catalog struct.
> According to what Andres is saying, it seems like we do (at least for
> ones with varlena fields).

Yes, I think there could be a problem.  I took a brief look through the
catalogs, and while there are plenty of catalogs with trailing padding,
finding that in combination with trailing varlena fields that might
legitimately be all null in practice might require a closer look.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ALTER TABLE on system catalogs
Next
From: Peter Eisentraut
Date:
Subject: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)