Clarify planner_hook calling convention - Mailing list pgsql-hackers

From Andrey V. Lepikhov
Subject Clarify planner_hook calling convention
Date
Msg-id 5eb6f0f3-4618-f835-ddc8-41c97b208551@postgrespro.ru
Whole thread Raw
Responses Re: Clarify planner_hook calling convention
List pgsql-hackers
Hi,

planner hook is frequently used in monitoring and advising extensions. 
The call to this hook is implemented in the way, that the 
standard_planner routine must be called at least once in the hook's call 
chain.

But, as I see in [1], it should allow us "... replace the planner 
altogether".
In such situation it haven't sense to call standard_planner at all. 
Moreover, if an extension make some expensive planning activity, 
monitoring tools, like pg_stat_statements, can produce different 
results, depending on a hook calling order.
I thought about additional hooks, explicit hook priorities and so on. 
But, maybe more simple solution is to describe requirements to such kind 
of extensions in the code and documentation (See patch in attachment)?
It would allow an extension developer legally check and log a situation, 
when the extension doesn't last in the call chain.


[1] 
https://www.postgresql.org/message-id/flat/27516.1180053940%40sss.pgh.pa.us

-- 
regards,
Andrey Lepikhov
Postgres Professional

Attachment

pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15
Next
From: Michael Paquier
Date:
Subject: Re: Confused comment about drop replica identity index