Re: pgsql: Add tests for reinit.c - Mailing list pgsql-committers

From David Steele
Subject Re: pgsql: Add tests for reinit.c
Date
Msg-id 5e50bfa0-411a-2a91-2417-ab31f74cda80@pgmasters.net
Whole thread Raw
In response to Re: pgsql: Add tests for reinit.c  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
List pgsql-committers
On 3/19/18 5:58 PM, Andrew Dunstan wrote:
> On Mon, Mar 19, 2018 at 11:33 PM, David Steele <david@pgmasters.net> wrote:
>> On 3/19/18 4:15 AM, Andrew Dunstan wrote:
>>>
>>> The attached fixes it. We should probably put the function or something
>>> like it in TestLib.pm, though. The call to pwd is quite tricky - it
>>> needs to be done pretty much exactly like this, not quite sure why, but
>>> direct calls to "pwd -W" via system() or backticks don't work, only this
>>> indirect call works on jacana.
>>
>> Thanks for the patch, Andrew!
>>
>> Peter, would you like me to provide a patch that moves this function to
>> TestLib.pm?  Happy to do it, just don't want patches crossing in the
>> night, as it were.
>>
> 
> I've reworked it and pushed the fix.

Thanks, Andrew!

-- 
-David
david@pgmasters.net


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pgsql: Set libpq sslcompression to off by default
Next
From: Tom Lane
Date:
Subject: pgsql: Prevent query-lifespan memory leakage of SP-GiST traversalvalue