On Mon, 2024-11-18 at 20:29 -0500, Corey Huinker wrote:
> Attached is a re-basing of the existing patchset, plus 3 more
> additions:
Comments on 0003:
* If we commit 0003, is it a useful feature by itself or does it
require that we commit some or all of 0004-0014? Which of these need to
be in v18?
* Why does binary upgrade cause statistics to be dumped? Can you just
make pg_upgrade specify the appropriate set of flags?
* It looks like appendNamedArgument() is never called with
positional=true?
* It's pretty awkward to use an array of arrays of strings when an
array of structs might make more sense.
Regards,
Jeff Davis