Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove redundant variable pageSize in gistinitpage - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Remove redundant variable pageSize in gistinitpage
Date
Msg-id 5c9107fd-bb16-0dee-fd56-6131685dcf87@enterprisedb.com
Whole thread Raw
In response to Remove redundant variable pageSize in gistinitpage  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
On 26.04.21 05:12, Bharath Rupireddy wrote:
> In gistinitpage, pageSize variable looks redundant, instead we could
> just pass BLCKSZ. This will be consistent with its peers
> BloomInitPage, brin_page_init and SpGistInitPage. Attaching a small
> patch. Thoughts?

Committed.

This code was new in this form in PG14 
(16fa9b2b30a357b4aea982bd878ec2e5e002dbcc), so it made sense to clean it 
up now.

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Adding more PGDLLIMPORTs
Next
From: "zhangjie2@fujitsu.com"
Date:
Subject: RE: [Patch] change the default value of shared_buffers in postgresql.conf.sample