On 2/24/22 07:19, Andrew Dunstan wrote:
> On 2/23/22 20:52, Tom Lane wrote:
>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>> On 23.02.22 23:58, Tom Lane wrote:
>>>> Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
>>>>> libpq TAP tests should be in src/interfaces/libpq/t/.
>>>> That's failing to account for the fact that a libpq test can't
>>>> really be a pure-perl TAP test; you need some C code to drive the
>>>> library.
>>> Such things could be put under src/interfaces/libpq/test, or some other
>>> subdirectory. We already have src/interfaces/ecpg/test.
>> OK, but then the TAP scripts are under src/interfaces/libpq/test/t,
>> which isn't what you said. I have no great objection to moving
>> src/test/modules/libpq_pipeline/ to src/interfaces/libpq/test/,
>> though, as long as the buildfarm will cope.
>>
>>
>
> It won't without some adjustment.
See
<https://github.com/PGBuildFarm/client-code/commit/ffc0fc029877632e9437af51bd99ace308daf0c8>
and
<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=crake&dt=2022-03-01%2010%3A47%3A22&stg=module-libpq-check>
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
