Re: perlcritic and perltidy - Mailing list pgsql-hackers

From Andrew Dunstan
Subject Re: perlcritic and perltidy
Date
Msg-id 5b5e8c07-1fd0-7d51-92a4-4d8f0f0f0891@2ndQuadrant.com
Whole thread Raw
In response to Re: perlcritic and perltidy  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Responses Re: perlcritic and perltidy  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers

On 05/08/2018 10:06 AM, Andrew Dunstan wrote:
> {         find . -type f -a \( -name
> '*.pl' -o -name '*.pm' \) -print;         find . -type f -perm -100
> -exec file {} \; -print                | egrep -i
> ':.*perl[0-9]*\>'                | cut -d: -f1;     }     | sort -u  |
> xargs perlcritic --quiet --single CodeLayout::RequireTrailingCommas



Here's a diff of all the places it found fixed. At this stage I don't
think it's worth it. If someone wants to write a perlcritic policy that
identifies missing trailing commas reasonably comprehensively, we can
look again. Otherwise we should just clean them up as we come across them.

cheers

andrew

-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: perlcritic and perltidy
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] path toward faster partition pruning