Re: pg_walinspect memory leaks - Mailing list pgsql-hackers

From Jeff Davis
Subject Re: pg_walinspect memory leaks
Date
Msg-id 5ae0f3e98c8d4053816d41d33a6fc372b73a09b1.camel@j-davis.com
Whole thread Raw
In response to Re: pg_walinspect memory leaks  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: pg_walinspect memory leaks
List pgsql-hackers
On Thu, 2023-02-16 at 18:00 +0530, Bharath Rupireddy wrote:
> I'm attaching the patches here. For HEAD, I'd
> want to be a bit defensive and use the temporary memory context for
> pg_get_wal_fpi_info() too.

I don't see why we shouldn't backpatch that, too?

Also, it seems like we should do the same thing for the loop in
GetXLogSummaryStats(). Maybe just for the outer loop is fine (the inner
loop is only 16 elements); though again, there's not an obvious
downside to fixing that, too.


--
Jeff Davis
PostgreSQL Contributor Team - AWS





pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Move defaults toward ICU in 16?
Next
From: Nathan Bossart
Date:
Subject: Re: O(n) tasks cause lengthy startups and checkpoints