Re: Add additional information to src/test/ssl/README - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Add additional information to src/test/ssl/README
Date
Msg-id 5EAAA715-AE57-4C1C-BC0B-6FA495389027@yesql.se
Whole thread Raw
In response to Re: Add additional information to src/test/ssl/README  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add additional information to src/test/ssl/README  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
> On 31 Oct 2021, at 19:28, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> Wouldn't it make more sense to start collecting troubleshooting advice in
>>> src/test/perl/README and instead refer to that in the boilerplate?  I notice
>>> that we don't document for example PG_TEST_NOCLEAN anywhere (which admittedly
>>> is my fault), a trubleshooting section in that file would be a good fit.
>
>> Yeah, we could try to move all the repetitive stuff to there.  I was a bit
>> allergic to the idea of having README files refer to webpages, because you
>> might be offline --- but referencing a different README doesn't have that
>> issue.
>
> Here's a quick stab at rearranging src/test/perl/README so that the
> initial section is all how-to-run-the-tests info, and advice about
> writing new tests starts after that.  Your point about PG_TEST_NOCLEAN
> could be added into the initial section.

That's pretty much just what I was thinking, definitely +1 on this patch.

> I'd envision adding something like
>
> "See src/test/perl/README for more info about running these tests."
>
> to the boilerplate "Running the tests" section in src/test/ssl/README
> and its cohorts, but I didn't bother with that yet.

Sounds good.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Thomas Munro
Date:
Subject: Re: Time to drop plpython2?
Next
From: Andres Freund
Date:
Subject: Re: should we enable log_checkpoints out of the box?