Re: Update stale code comment in CheckpointerMain() - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Update stale code comment in CheckpointerMain()
Date
Msg-id 5B10E53F-CF94-48B1-9EDA-D36A3CDC3F61@yesql.se
Whole thread Raw
In response to Re: Update stale code comment in CheckpointerMain()  (Amul Sul <sulamul@gmail.com>)
Responses Re: Update stale code comment in CheckpointerMain()
List pgsql-hackers
> On 1 Dec 2021, at 07:19, Amul Sul <sulamul@gmail.com> wrote:
> 
> On Tue, Nov 30, 2021 at 3:09 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>> 
>>> On 30 Nov 2021, at 08:00, Amul Sul <sulamul@gmail.com> wrote:
>> 
>>> The attached patch updates the code comment which is no longer true
>>> after commit # 4a92a1c3d1c361ffb031ed05bf65b801241d7cdd
>> 
>> Agreed, but looking at this shouldn't we also tweak the comment on
>> RecoveryInProgress() as per the attached v2 diff?
> 
> Yes, we should -- diff looks good to me, thanks.

Thanks for confirming, I've applied this to master.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: Optionally automatically disable logical replication subscriptions on error
Next
From: Amit Kapila
Date:
Subject: Re: Non-superuser subscription owners