pgindent complaint of the day - Mailing list pgsql-hackers

This case in xlog.c is representative of a disease that pgindent has had
for awhile:

@@ -4276,7 +4300,8 @@ StartupXLOG(void)               if (needNewTimeLine)    /* stopped because of stop request */
                 ereport(FATAL,                                       (errmsg("requested recovery stop point is before
endtime of backup dump")));
 
-               else                                    /* ran off end of WAL */
+               else
+/* ran off end of WAL */                       ereport(FATAL,                                       (errmsg("WAL ends
beforeend time of backup dump")));       }
 

I'm not sure of all the triggering conditions, but every so often it
decides to move a line-ending comment to its own line (which is a wrong
policy in the first place IMHO) and forgets to indent it.  I've mostly
seen it on "else" lines but I'm not sure that's the only case.
        regards, tom lane