Re: parallel.c is not marked as test covered - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: parallel.c is not marked as test covered
Date
Msg-id 58cd047c-deba-0863-b279-56b931237176@2ndquadrant.com
Whole thread Raw
In response to Re: parallel.c is not marked as test covered  (Noah Misch <noah@leadboat.com>)
Responses Re: parallel.c is not marked as test covered  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 6/7/16 11:43 PM, Noah Misch wrote:
> I changed this to keep the main message while overwriting the CONTEXT; a bug
> in this area could very well produce some other error rather than no error.

Regarding the patch that ended up being committed, I wonder if it is 
intentional that PL/pgSQL overwrites the context from the parallel 
worker.  Shouldn't the context effectively look like

ERROR:  message
CONTEXT:  parallel worker
CONTEXT:  PL/pgSQL function

Elsewhere in this thread I suggested getting rid of the parallel worker 
context by default (except for debugging), but if we do want to keep it, 
then it seems to be a bug that a PL/pgSQL function can just eliminate it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [COMMITTERS] pgsql: Don't generate parallel paths for rels with parallel-restricted
Next
From: Andres Freund
Date:
Subject: Re: Reviewing freeze map code