Re: Problem, partition pruning for prepared statement with IS NULL clause. - Mailing list pgsql-hackers

From Sergei Glukhov
Subject Re: Problem, partition pruning for prepared statement with IS NULL clause.
Date
Msg-id 5845262d-9b6a-71f7-3485-c06e4977586f@postgrespro.ru
Whole thread Raw
In response to Re: Problem, partition pruning for prepared statement with IS NULL clause.  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Problem, partition pruning for prepared statement with IS NULL clause.
List pgsql-hackers
Hi,

Thanks for fixing this!

I verified that issues are fixed.

On 10/11/23 11:50, David Rowley wrote:

> I'm aiming to commit these as two separate fixes, so I'm going to go
> look again at the first one and wait to see if anyone wants to comment
> on this patch in the meantime.

Regarding test case for the first patch,
the line 'set plan_cache_mode = 'force_generic_plan';' is not necessary
since cache mode is set at the top of the test. On the other hand test
scenario can silently  be loosed if someone set another cache mode
somewhere upper. As you mentioned earlier it's worth maybe adding
the test for run-time partition pruning.

Regards,
Gluh




pgsql-hackers by date:

Previous
From: tender wang
Date:
Subject: Re: Problem, partition pruning for prepared statement with IS NULL clause.
Next
From: Peter Smith
Date:
Subject: Re: Add null termination to string received in parallel apply worker