Re: [PATCH] Add result_types column to pg_prepared_statements view - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [PATCH] Add result_types column to pg_prepared_statements view
Date
Msg-id 58307e2c-a26c-d438-27f7-5bef9f693943@enterprisedb.com
Whole thread Raw
In response to [PATCH] Add result_types column to pg_prepared_statements view  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
Responses Re: [PATCH] Add result_types column to pg_prepared_statements view
List pgsql-hackers
On 19.05.22 17:34, Dagfinn Ilmari Mannsåker wrote:
> Prompted by a question on IRC, here's a patch to add a result_types
> column to the pg_prepared_statements view, so that one can see the types
> of the columns returned by a prepared statement, not just the parameter
> types.
> 
> I'm not quite sure about the column name, suggestions welcome.

I think this patch is sensible.

I see one issue: When you describe a prepared statement via the 
protocol, if a result field has a domain as its type, the RowDescription 
message sends the underlying base type, not the domain type directly 
(see SendRowDescriptionMessage()).  But it doesn't do that for the 
parameters (see exec_describe_statement_message()).  I don't know why 
that is; the protocol documentation doesn't mention it.  Might be worth 
looking into, and checking whether the analogous information contained 
in this view should be made consistent.



pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: replacing role-level NOINHERIT with a grant-level option
Next
From: Dilip Kumar
Date:
Subject: Re: making relfilenodes 56 bits